ephraimbuddy commented on issue #37617:
URL: https://github.com/apache/airflow/issues/37617#issuecomment-1960844138

   > Tested my changes
   > 
   > * [Fixing status icon alignment for various views 
#36804](https://github.com/apache/airflow/pull/36804) is not working as 
expected, not sure why. The changes are present here already 
https://github.com/apache/airflow/blob/v2-8-stable/airflow/www/static/js/dag/StatusBox.tsx
   > * [Revoking audit_log permission from all users except admin 
#37501](https://github.com/apache/airflow/pull/37501) needs the FAB provider 
changes, so we can probably only test it with that. How we do approach such 
cases @ephraimbuddy? Same applies for [Fix failing home view test after 
changing audit log permissions 
#37550](https://github.com/apache/airflow/pull/37550) and Fix wrong test after 
fixing audit log permission ([Fix wrong test after fixing audit log permission 
#37547](https://github.com/apache/airflow/pull/37547))
   
   @amoghrajesh , the #37501 was cherry-picked differently by @potiuk so it 
works in 2.8.2 without the provider, you can test it. Please check that the fix 
works. The same applies to the related PRs. 
   
   #36804 is not a blocker. It's minor
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to