uranusjr commented on code in PR #37005:
URL: https://github.com/apache/airflow/pull/37005#discussion_r1502174585


##########
tests/datasets/test_dataset.py:
##########
@@ -45,18 +45,31 @@ def clear_datasets():
         pytest.param("", id="empty"),
         pytest.param("\n\t", id="whitespace"),
         pytest.param("a" * 3001, id="too_long"),
-        pytest.param("airflow:" * 3001, id="reserved_scheme"),
-        pytest.param("๐Ÿ˜Š" * 3001, id="non-ascii"),
+        pytest.param("airflow://xcom/dag/task", id="reserved_scheme"),
+        pytest.param("๐Ÿ˜Š", id="non-ascii"),
+        pytest.param("ftp://user@localhost/foo.txt";, id="has-auth"),

Review Comment:
   Hmm, itโ€™s not trivial to propagate this to DagWarning. Iโ€™ll just remove the 
message altogether now and make this a follow-up issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to