Taragolis commented on code in PR #37711:
URL: https://github.com/apache/airflow/pull/37711#discussion_r1503048385
##########
airflow/settings.py:
##########
@@ -503,6 +503,15 @@ def import_local_settings():
setattr(airflow_local_settings, "task_policy",
airflow_local_settings.policy)
names.remove("policy")
+ if "SMTP_DEFAULT_TEMPLATED_SUBJECT" in names or
"SMTP_DEFAULT_TEMPLATED_HTML_CONTENT_PATH" in names:
+ warnings.warn(
+ "Configuring non-default `SMTP_DEFAULT_TEMPLATED_SUBJECT` and "
+ "`SMTP_DEFAULT_TEMPLATED_HTML_CONTENT_PATH` is deprecated.
Please upgrade to "
+ "the new version of the SMTP provider and use provider
configurations instead.",
+ AirflowProviderDeprecationWarning,
+ stacklevel=2,
+ )
+
Review Comment:
I'm not sure do we need this check if we consider that this settings
originally added by a mistake.
Let's wait what the other say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
