Taragolis commented on code in PR #37722:
URL: https://github.com/apache/airflow/pull/37722#discussion_r1503203442
##########
airflow/providers/google/cloud/transfers/gcs_to_local.py:
##########
@@ -87,13 +88,17 @@ def __init__(
) -> None:
# To preserve backward compatibility
# TODO: Remove one day
Review Comment:
Same here
##########
airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -546,28 +547,29 @@ def __init__(
) -> None:
# To preserve backward compatibility
# TODO: remove one day
Review Comment:
I'm pretty sure that this fallback broken for a long time, this part exists
before this code migrated from the `airflow.contrib` to the `providers` in
https://github.com/apache/airflow/pull/6077 I do not trace this change back.
`filter` parameter keep into the `kwargs` and pass to subclass and this will
raise an error that parameter not defined.
So another option just remove entire fallback block, since it do not work
well for more than 3-4 years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
