Taragolis commented on code in PR #37738:
URL: https://github.com/apache/airflow/pull/37738#discussion_r1503827994
##########
airflow/providers/http/hooks/http.py:
##########
@@ -268,6 +268,10 @@ def run_with_advanced_retry(self, _retry_args: dict[Any,
Any], *args: Any, **kwa
# TODO: remove ignore type when
https://github.com/jd/tenacity/issues/428 is resolved
return self._retry_obj(self.run, *args, **kwargs) # type: ignore
+ def url_from_endpoint(self, endpoint: str | None) -> str:
Review Comment:
I don't have an answer to this. In the one situation someone might use this
hook method internally and if we deprecate (and remove in the future) without
replacement it could be not fair, in the other hand I can't find this method,
with current and before remove implementation, useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
