jedcunningham commented on code in PR #37365:
URL: https://github.com/apache/airflow/pull/37365#discussion_r1506779642


##########
helm_tests/airflow_core/test_worker.py:
##########


Review Comment:
   I apologize, I should have explained why I thought that might be the case.
   
   You're testing the triggerer in the worker test file. And it's identical to 
what's in the triggerer test file.
   
   If you indented to move the testing from [this 
test](https://github.com/apache/airflow/blob/090a7f0707077320225e2cb4b1bc091c8fefee34/helm_tests/other/test_keda.py#L279)
 into here, that's okay too, but we should remove it over there so we are 
testing in 1 place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to