ferruzzi commented on code in PR #37786:
URL: https://github.com/apache/airflow/pull/37786#discussion_r1506930794
##########
airflow/providers/amazon/aws/executors/ecs/utils.py:
##########
@@ -85,30 +85,30 @@ class RunTaskKwargsConfigKeys(BaseConfigKeys):
ASSIGN_PUBLIC_IP = "assign_public_ip"
CAPACITY_PROVIDER_STRATEGY = "capacity_provider_strategy"
CLUSTER = "cluster"
Review Comment:
This is just sorted to alphabetize, it could have been a separate PR.
##########
airflow/providers/amazon/aws/executors/ecs/utils.py:
##########
@@ -85,30 +85,30 @@ class RunTaskKwargsConfigKeys(BaseConfigKeys):
ASSIGN_PUBLIC_IP = "assign_public_ip"
CAPACITY_PROVIDER_STRATEGY = "capacity_provider_strategy"
CLUSTER = "cluster"
+ CONTAINER_NAME = "container_name"
LAUNCH_TYPE = "launch_type"
PLATFORM_VERSION = "platform_version"
SECURITY_GROUPS = "security_groups"
SUBNETS = "subnets"
TASK_DEFINITION = "task_definition"
- CONTAINER_NAME = "container_name"
class AllEcsConfigKeys(RunTaskKwargsConfigKeys):
"""All keys loaded into the config which are related to the ECS
Executor."""
- MAX_RUN_TASK_ATTEMPTS = "max_run_task_attempts"
AWS_CONN_ID = "conn_id"
- RUN_TASK_KWARGS = "run_task_kwargs"
- REGION_NAME = "region_name"
CHECK_HEALTH_ON_STARTUP = "check_health_on_startup"
Review Comment:
This is just sorted to alphabetize, it could have been a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
