dirrao commented on code in PR #37784:
URL: https://github.com/apache/airflow/pull/37784#discussion_r1506965833


##########
airflow/models/taskinstance.py:
##########
@@ -2216,7 +2216,10 @@ def _check_and_change_state_before_execution(
 
         ti.state = TaskInstanceState.RUNNING
         ti.emit_state_change_metric(TaskInstanceState.RUNNING)
-        ti.external_executor_id = external_executor_id
+
+        if external_executor_id:

Review Comment:
   Make sense. I believe this piece of code runs on the worker side. So, do we 
have any use cases  where we change `external_executor_id` value from worker 
side?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to