jedcunningham commented on code in PR #37829:
URL: https://github.com/apache/airflow/pull/37829#discussion_r1509269574


##########
docs/apache-airflow/howto/set-config.rst:
##########
@@ -167,6 +167,34 @@ the example below.
     that you run airflow components on is synchronized (for example using 
ntpd) otherwise you might get
     "forbidden" errors when the logs are accessed.
 
+.. _set-config:configuring-local-settings:
+
+Configuring local settings
+==========================
+
+Some of Airflow configuration can be configured via local setting, because 
they require changes in the

Review Comment:
   ```suggestion
   Some Airflow configuration is configured via local setting, because they 
require changes in the
   ```



##########
docs/apache-airflow/howto/set-config.rst:
##########
@@ -167,6 +167,34 @@ the example below.
     that you run airflow components on is synchronized (for example using 
ntpd) otherwise you might get
     "forbidden" errors when the logs are accessed.
 
+.. _set-config:configuring-local-settings:
+
+Configuring local settings
+==========================
+
+Some of Airflow configuration can be configured via local setting, because 
they require changes in the
+code that is executed when airflow is initialized. Usually It is mentioned in 
the detailed documentation

Review Comment:
   ```suggestion
   code that is executed when Airflow is initialized. Usually It is mentioned 
in the detailed documentation
   ```



##########
docs/apache-airflow/howto/set-config.rst:
##########
@@ -167,6 +167,34 @@ the example below.
     that you run airflow components on is synchronized (for example using 
ntpd) otherwise you might get
     "forbidden" errors when the logs are accessed.
 
+.. _set-config:configuring-local-settings:
+
+Configuring local settings
+==========================
+
+Some of Airflow configuration can be configured via local setting, because 
they require changes in the
+code that is executed when airflow is initialized. Usually It is mentioned in 
the detailed documentation
+where you can configure such local settings - This is usually done in the 
``airflow_local_settings.py`` file.
+
+You should create ``airflow_local_settings.py`` file and put in on 
``$PYTHONPATH`` or
+to ``$AIRFLOW_HOME/config`` folder. (Airflow adds ``$AIRFLOW_HOME/config`` on 
``PYTHONPATH`` when

Review Comment:
   ```suggestion
   You should create a ``airflow_local_settings.py`` file and put it in a 
directory in ``sys.path`` or
   in the ``$AIRFLOW_HOME/config`` folder. (Airflow adds 
``$AIRFLOW_HOME/config`` to ``sys.path`` when
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to