ferruzzi commented on code in PR #37839:
URL: https://github.com/apache/airflow/pull/37839#discussion_r1509631372
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason:
str):
self.__class__.MAX_RUN_TASK_ATTEMPTS,
task_arn,
)
- self.active_workers.increment_failure_count(task_key)
+ if increment:
+ self.active_workers.increment_failure_count(task_key)
self.pending_tasks.appendleft(
EcsQueuedTask(
task_key,
task_cmd,
queue,
exec_info,
- failure_count + 1,
+ failure_count + 1 if increment else failure_count,
Review Comment:
I think it was just for convenience of not having
`self.active_workers.failure_count_by_key(task_key)` six times. How do you
feel about this alternative? I kinda like this, and unit tests like it too:
maybe rename it to get_failure_count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
