Taragolis commented on code in PR #37638:
URL: https://github.com/apache/airflow/pull/37638#discussion_r1510018666


##########
airflow/cli/commands/webserver_command.py:
##########
@@ -383,7 +383,7 @@ def webserver(args):
             "--workers",
             str(num_workers),
             "--worker-class",
-            str(args.workerclass),
+            "uvicorn.workers.UvicornWorker",

Review Comment:
   >[Running the 
application](https://connexion.readthedocs.io/en/latest/v3.html#running-the-application)
   There have been 2 changes related to running the application:
   >
   >You now MUST run the Connexion application instead of the underlying Flask 
application.
   >You should use an ASGI server instead of a WSGI server.
   
   So I guess there is no way to run Connexion 3 with default gunicorn workers 
because it is implements WSGI and `uvicorn.workers.UvicornWorker` adds ASGI 
support or it works as middleware, not sure. But maybe I miss something



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to