Taragolis commented on code in PR #37862:
URL: https://github.com/apache/airflow/pull/37862#discussion_r1510229260
##########
airflow/utils/pydantic.py:
##########
@@ -40,26 +40,22 @@ def is_pydantic_2_installed() -> bool:
from pydantic import BaseModel, ConfigDict, PlainSerializer,
PlainValidator, ValidationInfo
else:
- class BaseModel: # type: ignore[no-redef] # noqa
+ class BaseModel: # type: ignore[no-redef] # noqa: D101
def __init__(self, *args, **kwargs):
pass
- class ConfigDict: # type: ignore[no-redef] # noqa
+ class ConfigDict: # type: ignore[no-redef] # noqa: D101
def __init__(self, *args, **kwargs):
pass
- class PlainSerializer: # type: ignore[no-redef] # noqa
+ class PlainSerializer: # type: ignore[no-redef] # noqa: D101
def __init__(self, *args, **kwargs):
pass
- class PlainSerializer: # type: ignore[no-redef] # noqa
+ class PlainValidator: # type: ignore[no-redef] # noqa: D101
def __init__(self, *args, **kwargs):
pass
- class PlainValidator: # type: ignore[no-redef] # noqa
- def __init__(self, *args, **kwargs):
- pass
-
- class ValidationInfo: # type: ignore[no-redef] # noqa
Review Comment:
PlainValidator defined 2 times
##########
dev/breeze/src/airflow_breeze/breeze.py:
##########
@@ -23,24 +23,24 @@
find_airflow_sources_root_to_operate_on,
)
-from airflow_breeze.configure_rich_click import click # isort: skip # noqa
+from airflow_breeze.configure_rich_click import click # isort: skip # noqa:
F401
find_airflow_sources_root_to_operate_on()
create_directories_and_files()
-from airflow_breeze.commands import developer_commands # noqa
-from airflow_breeze.commands.ci_commands import ci_group # noqa
-from airflow_breeze.commands.ci_image_commands import ci_image # noqa
-from airflow_breeze.commands.kubernetes_commands import kubernetes_group #
noqa
-from airflow_breeze.commands.production_image_commands import prod_image #
noqa
-from airflow_breeze.commands.release_management_commands import
release_management # noqa
-from airflow_breeze.commands.minor_release_command import
create_minor_version_branch # noqa
-from airflow_breeze.commands.release_command import airflow_release # noqa
-from airflow_breeze.commands.release_candidate_command import
release_management # noqa
-from airflow_breeze.commands.sbom_commands import sbom # noqa
-from airflow_breeze.commands.setup_commands import setup # noqa
-from airflow_breeze.commands.testing_commands import group_for_testing # noqa
+from airflow_breeze.commands import developer_commands # noqa: I001, E402,
F401
+from airflow_breeze.commands.ci_commands import ci_group # noqa: E402
+from airflow_breeze.commands.ci_image_commands import ci_image # noqa: E402
+from airflow_breeze.commands.kubernetes_commands import kubernetes_group #
noqa: E402
+from airflow_breeze.commands.production_image_commands import prod_image #
noqa: E402
+from airflow_breeze.commands.release_management_commands import
release_management # noqa: E402
+from airflow_breeze.commands.minor_release_command import
create_minor_version_branch # noqa: E402, F401
+from airflow_breeze.commands.release_command import airflow_release # noqa:
E402, F401
+from airflow_breeze.commands.release_candidate_command import
release_management # noqa: E402, F811
Review Comment:
**F811**: `release_management` imported two times from
`airflow_breeze.commands.release_management_commands` and
`airflow_breeze.commands.release_candidate_command`, I do not change because
not sure may be first import required for something, because if it change it
the command hashes/images regenerated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
