uranusjr commented on PR #37856: URL: https://github.com/apache/airflow/pull/37856#issuecomment-1975854153
I don’t quite recall why we removed the `session=session` part in the change. It seems like a nice optimisation to commit eagerly when rendering nested fields. Maybe there are reasons. Since the current code works fine I guess it is worthwhile to at least try to remove the argument. `_do_render_template_fields` is supposed to be private-ish and shouldn’t be overriden very often. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
