Taragolis commented on code in PR #37873:
URL: https://github.com/apache/airflow/pull/37873#discussion_r1511113024
##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -245,8 +245,9 @@ def display_logs_from(log_group: str, continuation_token:
str | None) -> str | N
if e.response["Error"]["Code"] == "ResourceNotFoundException":
# we land here when the log groups/streams don't exist yet
self.log.warning(
- "No new Glue driver logs so far.\nIf this persists,
check the CloudWatch dashboard "
- f"at:
https://{self.conn_region_name}.console.aws.amazon.com/cloudwatch/home";
+ "No new Glue driver logs so far.\n"
+ "If this persists, check the CloudWatch dashboard at:
%r.",
+
f"https://{self.conn_region_name}.console.aws.amazon.com/cloudwatch/home";,
Review Comment:
Any reason for that? It is only arguments, not message itself.
In addition it only construct correct URI for default `aws` partition, but
not for `aws-cn` and maybe not for us-gov and secrets/top-secrets partitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
