kacpermuda opened a new pull request, #37877:
URL: https://github.com/apache/airflow/pull/37877
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Source of this PR is
[here](https://github.com/OpenLineage/OpenLineage/pull/2489), thanks
@BlackLight.
When using lineage_parent_id, a user should receive all the information
needed to create ParentRunFacet. Now we have this as `lineage_parent_id`
function:
https://github.com/apache/airflow/blob/30f7b2abe6991fe6e565f17f7d0701e80ecba0d3/airflow/providers/openlineage/plugins/macros.py#L60-L66
So as a job name, we get the UUID instead of `dag_id.task_id`. After the
change, we will be able to easily create ParentRunFacet:
```python
parent_id = lineage_parent_id(task_instance)
parent_namespace, parent_job_name, parent_run_id = parent_id.split("/")
parent_run_facet = ParentRunFacet.create(parent_run_id, parent_job_name,
parent_namespace)
```
Also, we are extracting the namespace again in macros module, when we have
one already extracted in adapter module, and this one is used in events so we
should use the same one here.
## Important
I am not sure if removing the `run_id` from the macro is a breaking change.
We could probably leave it there, but there is no real use in it i think.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
