ellisms commented on code in PR #37886:
URL: https://github.com/apache/airflow/pull/37886#discussion_r1511837763
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -55,22 +57,17 @@
from airflow.providers.amazon.aws.utils.tags import format_tags
from airflow.utils.helpers import chunks
-if TYPE_CHECKING:
- from mypy_boto3_s3.service_resource import Bucket as S3Bucket, Object as
S3ResourceObject
-
-T = TypeVar("T", bound=Callable)
-
logger = logging.getLogger(__name__)
-def provide_bucket_name(func: T) -> T:
+def provide_bucket_name(func: Callable) -> Callable:
Review Comment:
It's minor cleanup - isn't the base definition more of a Java thing? It's
not required for the changes to resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]