o-nikolas commented on code in PR #37881:
URL: https://github.com/apache/airflow/pull/37881#discussion_r1511945554
##########
airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -263,8 +261,10 @@ def is_authorized_variable(
return self._is_authorized(method=method,
resource_type=RESOURCE_VARIABLE, user=user)
def is_authorized_view(self, *, access_view: AccessView, user: BaseUser |
None = None) -> bool:
+ # Docs are just links the menu and not pages
Review Comment:
Can you expand/refine this just a little bit more? I'm a little confused
what it means, I think it's missing just one or two words.
##########
airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -463,18 +463,11 @@ def _get_user_permissions(user: BaseUser):
"""
Return the user permissions.
- ACTION_CAN_READ and ACTION_CAN_ACCESS_MENU are merged into because
they are very similar.
- We can assume that if a user has permissions to read variables, they
also have permissions to access
- the menu "Variables".
Review Comment:
I'm curious, what changed so that this is no longer true? There is no
description on this PR or linked issue explaining the context :grimacing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
