mewa commented on code in PR #37197:
URL: https://github.com/apache/airflow/pull/37197#discussion_r1512930492
##########
chart/templates/rbac/pod-launcher-role.yaml:
##########
@@ -28,15 +28,20 @@ kind: ClusterRole
kind: Role
{{- end }}
metadata:
- name: {{ include "airflow.fullname" . }}-pod-launcher-role
{{- if not .Values.multiNamespaceMode }}
+ name: {{ include "airflow.fullname" . }}-pod-launcher-role
namespace: "{{ .Release.Namespace }}"
+ {{- else }}
+ name: {{ include "airflow.fullname" . }}-{{ .Release.Namespace
}}-pod-launcher-role
Review Comment:
I don't have strong opinions on this. I feel like labels should be the
default way to interact with objects anyway (especially past a point where this
starts to matter). But I guess it does make sense to have it grouped by
namespace, so let's just change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
