Taragolis opened a new pull request, #37912:
URL: https://github.com/apache/airflow/pull/37912
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
I'm not sure is it version of some dependency, or this test do not executed
for a while so we miss some regression.
But it constantly failed into the main into this days. I've tried to go back
to couple (hundreds) recommit back but it faild with the same error, no
expected `aiflow-version` in labels
```console
E AssertionError: expected call not found.
E Expected: start_java_pipeline(variables={'project': <MagicMock
name='DataflowHook().project_id' id='140546784028304'>, 'jobName': <MagicMock
name='DataflowHook.build_dataflow_job_name()' id='140546788564880'>,
'stagingLocation': 'gs://test/staging', 'region': 'us-central1', 'labels':
{'foo': 'bar', 'airflow-version': 'v2-9-0-dev0'}, 'output': 'gs://test/output',
'impersonateServiceAccount': '[email protected]'}, jar=<MagicMock
name='GCSHook().provide_file().__enter__().name' id='140546878230224'>,
job_class='com.test.NotMain', process_line_callback=<ANY>)
E Actual: start_java_pipeline(variables={'project': <MagicMock
name='DataflowHook().project_id' id='140546784028304'>, 'stagingLocation':
'gs://test/staging', 'impersonateServiceAccount': '[email protected]',
'region': 'us-central1', 'labels': {'foo': 'bar'}, 'output':
'gs://test/output', 'jobName': <MagicMock
name='DataflowHook.build_dataflow_job_name()' id='140546788564880'>},
jar=<MagicMock name='GCSHook().provide_file().__enter__().name'
id='140546878230224'>, job_class='com.test.NotMain',
process_line_callback=<function
process_line_and_extract_dataflow_job_id_callback.<locals>._process_line_and_extract_job_id
at 0x7fd39751cae0>)
E
E pytest introspection follows:
E
E Kwargs:
E assert equals failed
E { {
E 'jar': <MagicMock name='GCSHo 'jar': <MagicMock name='GCSHo
E ok().provide_file().__enter__() ok().provide_file().__enter__()
E .name' id='140546878230224'>, .name' id='140546878230224'>,
E 'job_class': 'com.test.NotMai 'job_class': 'com.test.NotMai
E n', n',
E 'process_line_callback': <fun 'process_line_callback': <ANY
E ction process_line_and_extract_ >,
E dataflow_job_id_callback.<local
E s>._process_line_and_extract_jo
E b_id at 0x7fd39751cae0>,
E 'variables': { 'variables': {
E 'impersonateServiceAccount' 'impersonateServiceAccount'
E : '[email protected]', : '[email protected]',
E 'jobName': <MagicMock name= 'jobName': <MagicMock name=
E 'DataflowHook.build_dataflow_jo 'DataflowHook.build_dataflow_jo
E b_name()' id='140546788564880'> b_name()' id='140546788564880'>
E , ,
E 'labels': { 'labels': {
E 'airflow-version': 'v2-9-
E 0-dev0',
E 'foo': 'bar', 'foo': 'bar',
E }, },
E 'output': 'gs://test/output 'output': 'gs://test/output
E ', ',
E 'project': <MagicMock name= 'project': <MagicMock name=
E 'DataflowHook().project_id' id= 'DataflowHook().project_id' id=
E '140546784028304'>, '140546784028304'>,
E 'region': 'us-central1', 'region': 'us-central1',
E 'stagingLocation': 'gs://te 'stagingLocation': 'gs://te
E st/staging', st/staging',
E }, },
E } }
tests/providers/apache/beam/operators/test_beam.py:300: AssertionError
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
