htpawel commented on PR #30612: URL: https://github.com/apache/airflow/pull/30612#issuecomment-1980985307
@vandonr-amz @potiuk Hi, Above change has two bugs. One is that Stats.timing expects milliseconds instead of seconds (PR with fix: [37936](https://github.com/apache/airflow/pull/37936/files)) and second one is that scheduled_duration metric does not work as `self.start_date` is always None at time of execution of this. It is because `self.start_date` is not corresponding to time of schedule (real start) but to actual running start (after scheduled and queued states), see comment here: [34771#discussion_r1432601056](https://github.com/apache/airflow/pull/34771#discussion_r1432601056). I think something with naming convention should be done as it can be very misleading, and also we need some scheduled_dttm variable like stated in the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
