vincbeck commented on PR #37915: URL: https://github.com/apache/airflow/pull/37915#issuecomment-1985892661
Actually, let me explain why I combined the two. The idea initially was to call `is_authorized_custom_view`in this case: https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py#L512. This case is when there is a custom menu item in the menu added by a plugin. This was my initial idea. But since recently in #37881 we added the action `MENU`, the idea was to use it as well. I can definitely do it in 2 PRs but that would mean implementing something with unit tests associated, and deleting this exact same code I just implemented in a follow-up PRs to take into consideration the action `MENU`. Though, I am still happy to make this effort if you think that would make the review easier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
