vincbeck commented on code in PR #37947:
URL: https://github.com/apache/airflow/pull/37947#discussion_r1517873411


##########
airflow/providers/amazon/aws/auth_manager/views/auth.py:
##########
@@ -93,7 +93,7 @@ def login_callback(self):
             user_id=attributes["id"][0],
             groups=attributes["groups"],
             username=saml_auth.get_nameid(),
-            email=attributes["email"][0],
+            email=attributes["email"][0] if "email" in attributes else None,

Review Comment:
   Yeah I supposed it made sense to include the fix as part of the same PR as 
the test? But I can also create a separate PR for it. I am fine either way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to