Taragolis commented on code in PR #38010:
URL: https://github.com/apache/airflow/pull/38010#discussion_r1518573347
##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -112,6 +112,7 @@ def __init__(
kwargs["client_type"] = "glue"
super().__init__(*args, **kwargs)
+ self.logs_hook = AwsLogsHook(aws_conn_id=self.aws_conn_id)
Review Comment:
Better move it out of the Hook constructor, into the property because this
is optional and not requiredo all operations.
And in addition it also a good idea to propagate also all generic
parameters, like region_name, verify and config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
