eladkal commented on code in PR #38049:
URL: https://github.com/apache/airflow/pull/38049#discussion_r1521054450
##########
airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py:
##########
@@ -607,7 +609,7 @@ class
DeleteAutoMLTrainingJobOperator(GoogleCloudBaseOperator):
AutoMLTabularTrainingJob, AutoMLTextTrainingJob, or AutoMLVideoTrainingJob.
"""
- template_fields = ("training_pipeline", "region", "project_id",
"impersonation_chain")
+ template_fields = ("training_pipeline_id", "region", "project_id",
"impersonation_chain")
Review Comment:
I think removing training_pipeline from the list is a breaking change.
Can you add a test to verify that `training_pipeline` is still rendered with
Jinja even if you remove it from the `template_fields`? If the test doesn't
pass then we need to keep it in the `template_fields` till we remove support
for this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
