potiuk opened a new pull request, #38077:
URL: https://github.com/apache/airflow/pull/38077
GitHub actions has strange and complex way of getting conditional jobs. When
you want a job to depend on another job to be running when it is either
successful of fully skipped, you have to write a rather peculiar condition:
```
always() && !failure() && !cancelled()
```
However, it turned out that this condition does not propoagate to to task
that depends on the downstream tasks - for example if "wait-for-ci-images" had
this condition and preceding "build-ci-images" was skipped, the
"wait-for-ci-images" was happily running, but any of the other jobs that
depended on "wait-for-ci-images" has been skipped :(. Simply - skipping tasks
immediately propagates to all the downstream tasks and we cannot easily
mitigate it.
This means that we have to come back to a solution that was implemented
before #38057 - where instead of skipping the whole job, we skip all the steps
in this kob. That makes it a little more clunky but makes the skipping status
not propagate to downstream jobs.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
