shahar1 commented on code in PR #38048:
URL: https://github.com/apache/airflow/pull/38048#discussion_r1522172634
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -1355,6 +1357,26 @@ def __init__(
self.gcp_conn_id = gcp_conn_id
self.impersonation_chain = impersonation_chain
+ @property
Review Comment:
They serve as aliases for the renamed public properties
'self.training_pipeline_id` and `self.custom_job_id` to avoid breaking
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -1355,6 +1357,26 @@ def __init__(
self.gcp_conn_id = gcp_conn_id
self.impersonation_chain = impersonation_chain
+ @property
Review Comment:
They serve as aliases for the renamed public properties
`self.training_pipeline_id` and `self.custom_job_id` to avoid breaking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
