eladkal commented on code in PR #38079:
URL: https://github.com/apache/airflow/pull/38079#discussion_r1522580067
##########
airflow/providers/slack/transfers/sql_to_slack.py:
##########
@@ -134,6 +141,8 @@ def execute(self, context: Context) -> None:
output_file_name = fp.name
output_file_format = output_file_format.upper()
df_result = self._get_query_results()
+ if not self.allow_null and df_result.empty:
+ raise SqlToSlackNullOutputException("Sql output is empty.")
Review Comment:
I think it makes sense but in this case probably we need another rename.
Something like `set_skip_on_empty_result`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
