potiuk commented on code in PR #38095:
URL: https://github.com/apache/airflow/pull/38095#discussion_r1522709638
##########
dev/breeze/pyproject.toml:
##########
@@ -51,6 +51,9 @@ dependencies = [
"flit>=3.5.0",
"gitpython>=3.1.40",
"hatch==1.9.1",
+ # Importib_resources 6.2.0 break pytest_rewrite
+ # see https://github.com/python/importlib_resources/issues/299
+ "importlib_resources>=5.2,<6.2.0;python_version<\"3.9\"",
Review Comment:
Maybe yes, maybe no. Maybe 6.3.1 will be fixed, and maybe 6.4.0 will be
broken and only 6.5.0 will fix it. I craeted the issue and have not yet heard
from importlib_resources maintainers. Or maybe pytest will release new version
that is not crashing on 6.2.0 or 6.3.0 and we add `pytest >= x.y.z`.
This is pure speculation.
This is `living` main and we can always change it in the future when we know
how to deal with it. For now limiting it to < 6.2 is safer and more accurate
(for now we know that below 6.2.0 we are safe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
