eladkal commented on PR #37223:
URL: https://github.com/apache/airflow/pull/37223#issuecomment-1995201673

   > Hey, Michal from Cloud Composer team here.
   +1 for this code living in a separate, GDC provider - GDC is based on 
slightly different infra than GCP, and the operators won't necessarily work in 
the same way (some might be very similar, some very different).
   
   Given the above statemant and the fact that we are going to seprate google 
to several providers we should treat this PR like adding a new provider which 
means it nreds to go through the approval cycle like all other providers.
   
https://github.com/apache/airflow/blob/main/PROVIDERS.rst#accepting-new-community-providers
   
   > If there's shared code, I propose having a util module/provider between 
these two.
   
   That will not work and this is one of the reason why seperating Google 
provider is not an easy task. You can't have utill shared between two 
providers. Utill belongs to one provider. Maybe Google can intoduce 
google.common provider but that would require separate discussion.
   I really advise against adding more completely to Google provider it will 
make things harder for the decouple project 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to