kaxil commented on a change in pull request #5928: [AIRFLOW-5168] Fix Dataproc 
Operators & add tests
URL: https://github.com/apache/airflow/pull/5928#discussion_r318542223
 
 

 ##########
 File path: tests/contrib/operators/test_dataproc_operator.py
 ##########
 @@ -492,6 +522,27 @@ def test_update_cluster(self):
                 })
             hook.wait.assert_called_once_with(self.operation)
 
+    def test_render_template(self):
 
 Review comment:
   They are actually checking to template :D
   
   `DataprocClusterScaleOperator` is passed  `GCP_PROJECT_TEMPLATED`, 
`CLUSTER_NAME_TEMPLATED` etc which are defined at the top of the file 
containing Jinja templated strings.
   
   And while asserting we check `GCP_PROJECT` & ` `CLUSTER_NAME` containing 
rendered fields

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to