Taragolis commented on code in PR #38164:
URL: https://github.com/apache/airflow/pull/38164#discussion_r1525548685
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -168,6 +168,11 @@ def _change_directory_permissions_up(directory: Path,
folder_permissions: int):
:param directory: directory to change permissions of (including parents)
:param folder_permissions: permissions to set
"""
+ if directory.resolve() == Path.home().resolve():
Review Comment:
I think about other case, maybe not really common but I guess pretty
popular, run under `root` ⚠️⚠️⚠️ user
In linux usually home directory is `/root` and lets imagine that logs stored
into the `/opt/airflow/logs/foo/bar`, so lookup would be
- `/opt/airflow/logs/foo/bar`
- `/opt/airflow/logs/foo`
- `/opt/airflow/logs`
- `/opt/airflow`
- `/opt`
- `/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
