amoghrajesh commented on PR #38062: URL: https://github.com/apache/airflow/pull/38062#issuecomment-1998890835
> I don't think tagging is done? I could not find it actually ? Where is it tagged? I believe the previous steps only use existing tags but never tag it ? Or maybe I missed it ? Maybe I am slightly mistaken here but I was checking the process logs. We have this happening in the step "Helm release tarball" ``` Run breeze release-management prepare-helm-chart-tarball --ignore-version-check --override-tag --skip-tag-signing --version 0.0.0 --version-suffix dev0 Airflow version in values.yaml: 2.8.3 Default Airflow Tag in values.yaml: 2.8.3 Airflow version in Chart.yaml: 2.8.3 Version in chart.yaml (1.[14](https://github.com/apache/airflow/actions/runs/8278547604/job/22651378456?pr=38062#step:9:15).0-dev) does not match the version passed as parameter (0.0.0). Updating Airflow version in chart.yaml matches the airflow version in values.yaml: (2.8.3) Versions of the chart has been updated Ignoring the version check. The tarball will be created but it should not be published Tagging the chart with helm-chart/0.0.0dev0 Creating tarball for Helm Chart helm-chart/0.0.0dev0 Tarball created in /home/runner/actions-runner/_work/airflow/airflow/dist/airflow-chart-0.0.0-source.tar.gz ``` And in this breeze command the following happens ``` if not skip_tagging: get_console().print(f"[info]Tagging the chart with {tag_with_suffix}[/]") tag_command = [ "git", "tag", tag_with_suffix, "-m", f"Apache Airflow Helm Chart {version}{version_suffix}", ] if override_tag: tag_command.append("--force") if not skip_tag_signing: tag_command.append("--sign") result = run_command(tag_command, check=False) if result.returncode != 0: get_console().print(f"[error]Error tagging the chart with {tag_with_suffix}.\n") get_console().print( "[warning]If you are sure the tag is set correctly, you can add --skip-tagging" " flag to the command[/]" ) sys.exit(result.returncode) else: get_console().print(f"[warning]Skipping tagging the chart with {tag_with_suffix}[/]") get_console().print(f"[info]Creating tarball for Helm Chart {tag_with_suffix}[/]") ``` So I think it has a tag now. I will check out what the right one is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
