Taragolis commented on code in PR #38178:
URL: https://github.com/apache/airflow/pull/38178#discussion_r1526387882
##########
airflow/providers/amazon/aws/operators/base_aws.py:
##########
@@ -85,10 +86,12 @@ def __init__(
region_name: str | None = None,
verify: bool | str | None = None,
botocore_config: dict | None = None,
+ region: str | None | ArgNotSet = NOTSET, # Required for `.partial`
signature check
**kwargs,
):
+ additional_params = {} if region is NOTSET else {"region": region}
hook_params = AwsHookParams.from_constructor(
- aws_conn_id, region_name, verify, botocore_config,
additional_params=kwargs
+ aws_conn_id, region_name, verify, botocore_config,
additional_params=additional_params
Review Comment:
The only one purpose it is create frozen dataclass in constructor and
resolve `region_name` and `region` in AwsBaseOperator / AwsBaseSensor, the
object do not exposed anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
