potiuk opened a new pull request, #38200:
URL: https://github.com/apache/airflow/pull/38200
When running tests in parallel in our CI we switched off showing success
outputs by default in #38157. This is generally a good thing, because it only
shows outputs for the test types that failed and makes the CI log output far
snappier in case only one or few test types failed.
However it also has a side effect that it's
not really easy to see what kind of commands were run in each parallel test
type, so we might get accidentally some mistakes where we miss that our tests
are not doing what we think they are doing - for example not running tests for
various Python versions, only for one, or not running them for various database
versions (both cases happened in the past). By hiding the success outputs, we
make it harder to spot such issues.
This PR introduces two ways to improve it:
* we can now set a label on PR to `include success outputs` and any
committer can set the label to show success outputs as well.
* When we run parallel unit tests we summarize what is going to be executed
- showing all the ShellParams passed to the parallel test execution. This is
the best place to show it because this ShellParams object contains all the
actual values passed - after processing throught options, special environment
variables and so-on - so those are the actual values used to run the parallel
tests.
Also it will be printed in a prominent place - just before test execution in
the main console output, which means it will be visible without the need to
unfold any output.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
