[
https://issues.apache.org/jira/browse/AIRFLOW-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918245#comment-16918245
]
ASF GitHub Bot commented on AIRFLOW-4833:
-----------------------------------------
galak75 commented on pull request #5943: [AIRFLOW-4833] Allow to set Jinja env
options in DAG declaration
URL: https://github.com/apache/airflow/pull/5943
Make sure you have checked _all_ steps below.
### Jira
- [ x ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-4833) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4833
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ x ]
- Issue was : a trailing newline in a template string is dropped by Jinja2
(default behavior)
- This is fixed by allowing to set options to `jinja2.Environment` object by
defining these options at the DAG level (see
[AIRFLOW-4833](https://issues.apache.org/jira/browse/AIRFLOW-4833) for more
information)
### Tests
- [ x ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ x ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ x ] In case of new functionality, my PR adds documentation that
describes how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ x ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Jinja templating removes newlines
> ---------------------------------
>
> Key: AIRFLOW-4833
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4833
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.2
> Reporter: Francesco Macagno
> Assignee: Galak
> Priority: Minor
>
> When using an operator that has Jinja templating enabled for a field, if the
> field value ends with a newline then the newline is removed, regardless of
> whether there was a template in the string.
>
> This came up when attempting to send data to Prometheus pushgateway using the
> SimpleHttpOperator. Pushgateway requires a newline at the end of every entry,
> so the removal of the newline at the end of the data parameter causes the
> request to fail in a way that is difficult to debug.
>
> This can be gotten around by including a space after the newline character,
> though this is not a great solution. The space is ignored by pushgateway.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
