ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1530496624
##########
airflow/providers/amazon/aws/operators/neptune.py:
##########
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts = waiter_max_attempts
- def execute(self, context: Context) -> dict[str, str]:
+ def execute(self, context: Context, event: dict[str, Any] | None = None,
**kwargs) -> dict[str, str]:
Review Comment:
Looks like execute is deferred in the EMR operator:
https://github.com/apache/airflow/blob/2cc2f5e7d1307a02c5ed9cd96e7c5688dae622b1/airflow/providers/amazon/aws/operators/emr.py#L1361
I wanted to avoid duplicate code, so if `execute` can handle all the
exception handling, it seemed like a cleaner solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
