Taragolis commented on code in PR #38333:
URL: https://github.com/apache/airflow/pull/38333#discussion_r1532443697


##########
airflow/providers/amazon/aws/auth_manager/avp/facade.py:
##########
@@ -222,6 +224,19 @@ def get_batch_is_authorized_single_result(
         )
         raise AirflowException("Could not find the authorization result.")
 
+    def is_policy_store_schema_up_to_date(self) -> bool:
+        """Return whether the policy store schema equals the latest version of 
the schema."""
+        resp = self.avp_client.get_schema(
+            policyStoreId=self.avp_policy_store_id,
+        )
+        policy_store_schema = json.loads(resp["schema"])
+
+        schema_path = Path(__file__).parents[0] / "schema.json"
+        with open(schema_path) as schema_file:
+            latest_schema = json.loads(schema_file.read())

Review Comment:
   Minor nit, I guess `json.load` do the same things infernally
   
   ```suggestion
               latest_schema = json.load(schema_file)
   ```
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to