dwreeves opened a new issue, #38337:
URL: https://github.com/apache/airflow/issues/38337
### Description
Right now, if you try doing something like the below, the timezone is
completely ignored:
```python
from pendulum import Time
from airflow.sensors.time_sensor import TimeSensorAsync
import pytz
wait_for_start_of_business = TimeSensorAsync(
task_id="wait_for_business_hours",
target_time=Time(9, 0, tzinfo=pytz.timezone("America/New_York")),
)
```
The timezone is completely ignored.
It would be nice if the timezone were not ignored in this case. I think the
change that would need to occur in the code would be to replace this:
```python
aware_time = timezone.coerce_datetime(
datetime.datetime.combine(datetime.datetime.today(), self.target_time,
self.dag.timezone)
)
```
with this:
```python
tz = self.target_time.tzinfo or self.dag.timezone
aware_time = timezone.coerce_datetime(
datetime.datetime.combine(datetime.datetime.now(tz=tz),
self.target_time, tz)
)
```
This is backwards compatible so long as:
- The `time` does not have a `tzinfo` _or_ alternatively the `tzinfo` is
equal to `self.dag.timezone`
- The `self.dag.timezone` agrees with the system time. This is a weird one,
as I would argue the previous behavior was a minor bug: e.g.
`datetime.datetime.today()` running on Jan 2nd at 03:00:00+0600 (i.e. 6 hours
ahead of UTC) will output Jan 2nd even though it is Jan 1st in UTC, so if the
system is `+0600` and the DAG is `+0000`, the sensor will potentially never
fire.
(While we are at it, `TimeSensor` is untyped, so some type annotations could
be added during this PR.)
### Use case/motivation
I have a Slack notification system that needs to wait until 9am EST before
it's allowed to fire off notifications. What constitutes 9am EST in UTC time
(which is our Airflow server's timezone) differs depending on daylight savings.
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
