ashb commented on a change in pull request #5913: Change SQLSensor to treat
NULL as keep poking.
URL: https://github.com/apache/airflow/pull/5913#discussion_r319019205
##########
File path: airflow/sensors/sql_sensor.py
##########
@@ -102,6 +98,4 @@ def poke(self, context):
return self.success(first_cell)
else:
raise AirflowException("self.success is present, but not
callable -> {}".format(self.success))
- if self.allow_null:
- return str(first_cell) not in ('0', '')
return str(first_cell) not in ('0', '', 'None')
Review comment:
Waaaait. I just noticed. This means if I do `INSERT VALUES("None")` in my
table it would fail. That is a bug in the original PR that we need to fix first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
