ashb commented on a change in pull request #5688: [AIRFLOW-5073] Treat NULL as
keep poking in SQL sensor
URL: https://github.com/apache/airflow/pull/5688#discussion_r319020780
##########
File path: airflow/sensors/sql_sensor.py
##########
@@ -98,4 +102,6 @@ def poke(self, context):
return self.success(first_cell)
else:
raise AirflowException("self.success is present, but not
callable -> {}".format(self.success))
- return str(first_cell) not in ('0', '')
+ if self.allow_null:
+ return str(first_cell) not in ('0', '')
+ return str(first_cell) not in ('0', '', 'None')
Review comment:
(And although not a new bug, this won't work if the type is floating point,
that would give us 0.0 as a value)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
