uranusjr commented on code in PR #38309:
URL: https://github.com/apache/airflow/pull/38309#discussion_r1533064816
##########
tests/providers/fab/auth_manager/test_security.py:
##########
@@ -997,7 +997,7 @@ def test_parent_dag_access_applies_to_subdag(app,
security_manager, assert_user_
session.add_all([dag1, dag2, dag3])
session.commit()
security_manager.bulk_sync_roles(mock_roles)
- for dag in [dag1, dag2, dag3]:
+ for _ in [dag1, dag2, dag3]:
security_manager._sync_dag_view_permissions(
parent_dag_name, access_control={role_name: READ_WRITE}
)
Review Comment:
This seems off… why are we doing the same sync three times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
