ephraimbuddy commented on PR #38155: URL: https://github.com/apache/airflow/pull/38155#issuecomment-2011336350
> > > This would be rather hacky. Likely better to add a new method `on_task_instanc_failed_with_error` > > > > > > surely possible, but it doesn't look very clean... And even if we obsolete the other method, we'll be stuck with the weird name. > > Would it make it less hacky if the field was added as a proper class field to `TaskInstance` ? > > TaskInstance is a Data Model. We should not add extra fields there which are not related to DataModel. We have done that in the past and it was not good.. That **really** is hacky. I had an idea for this type of stuff but it seemed disruptive - have a state data model that includes a message field in which we can store errors like this https://github.com/apache/airflow/pull/37896/files. I think, that's the best way to capture these kinds of errors seamlessly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
