Taragolis opened a new pull request, #38366:
URL: https://github.com/apache/airflow/pull/38366
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
That what I've accidentally found, that we install `importlib_metadata` only
for Python 3.8 however in some places we might use in more modern versions of
the Python when we use
```python
try:
import importlib_metadata as metadata
except ImportError:
from importlib import metadata
```
Right now `importlib_metadata` as well as (`importlib_resources`) presented
into the Docker Image (2.8.4rc1), more like it comes from one of the
dependency.
So this could be a situation that we unintendedly use some features from the
backported packages and it works as expected, because this package also provide
new feature which will added into the `stdlib` in the future, see [compat
table](https://github.com/python/importlib_metadata/?tab=readme-ov-file#compatibility)
| **importlib_metadata** | **stdlib** |
|------------------------|------------|
| 7.0 | 3.13 |
| 6.5 | 3.12 |
| 4.13 | 3.11 |
| 4.6 | 3.10 |
| 1.4 | 3.8 |
I've tried to found places where the behavior in stdlib changed
(https://docs.python.org/3/library/importlib.metadata.html), and only found two
places which we use in Airflow code base
- Entrypoints: in 3.6 (not relevant), 3.10 and 3.12
- Distribution metadata: In 3.10 (maybe also not our case)
This PR is attempt to prevent that something work just because some
dependency install `importlib_metadata` and our code just always use
`importlib_metadata` if it installed. This might help to detect some
minor/major incompatabilities
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
