Re: [PR] Migrate to connexion v3 [airflow]

[via GitHub]

vincbeck commented on PR #37638:
URL: https://github.com/apache/airflow/pull/37638#issuecomment-2015557108

   > ### Does not raise Valueerror
   > This test seems not to raise `ValueError` anymore after migrating to 
connexion v3. See **screenshot 1**. But a ValueError is indeed raised from deep 
inside the `Connexion` library. Need some context on what this test is testing. 
Also suggestion on possible rewrite.
   > 
   > 
https://github.com/apache/airflow/blob/947c48b2fbfaed59068e4a06e223cf501cc1227f/tests/www/api/experimental/test_dag_runs_endpoint.py#L98-L106
   > 
   > **Screenshot 1**
   > 
   > <img alt="Screenshot 2024-03-22 at 12 50 41 PM" width="791" 
src="https://private-user-images.githubusercontent.com/32765701/316107238-40cd380e-0939-4851-8e43-279ed6f63e95.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTExMjgyOTcsIm5iZiI6MTcxMTEyNzk5NywicGF0aCI6Ii8zMjc2NTcwMS8zMTYxMDcyMzgtNDBjZDM4MGUtMDkzOS00ODUxLThlNDMtMjc5ZWQ2ZjYzZTk1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzIyVDE3MTk1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNkOGQ4OTIxZjFhNjY3Yjg3NjNmMTgzOTkyZWNlYzVhMTVjMDYyNWY1ZmM5ZDU3NmExZTQwNTMyZDM5NGRhYTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KUFWFBOmodbKxTQ1z-axFEmr7MH7Sa8srFahChmXxHQ";>
   > **An exception occurred deep inside the library but was not propagated.**
   > 
   > <img alt="Screenshot 2024-03-22 at 12 50 24 PM" width="893" 
src="https://private-user-images.githubusercontent.com/32765701/316107584-ec602400-a53e-4e6a-8b11-656b0be413c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTExMjgyOTcsIm5iZiI6MTcxMTEyNzk5NywicGF0aCI6Ii8zMjc2NTcwMS8zMTYxMDc1ODQtZWM2MDI0MDAtYTUzZS00ZTZhLThiMTEtNjU2YjBiZTQxM2MzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzIyVDE3MTk1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxOTk1NWNmMTU3Mjg5NzkwZjM1YzNkMTJhOGM5NmU5OGZkNmEwMTcxNDRkNzM3NmNhMGE3MjE2NGJhNDRkZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4Aip4eE8wSnsGCi6ev8ANzZm_cyGUa0PoIOIrK_Lk98";>
   
   Since is it API experimental, I would not spend too much time on it. Maybe 
change the expected exception? Change it to expect `ValueError` from 
`connexion` library


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org