lyuyunbo commented on PR #38008: URL: https://github.com/apache/airflow/pull/38008#issuecomment-2016091345
> Still try/finally not solved Can you be more specific please @potiuk? Because we indeed added `_restore_log_formatter` into the except clause, which will revert the changes if formatters are not fully updated to the customized one. If you are referring to the original suggestion: > Maybe I am nissing something I thought about try/finally where _restore_log_formatter will be called in the finally clause. I think we've confused something here, because `_restore_log_formatter` will roll back all formatters no matter the try block succeeded or not, and makes this feature not working anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
