potiuk opened a new pull request, #38437:
URL: https://github.com/apache/airflow/pull/38437
While currently hatchling and pip nicely supports dynamic replacement of the
dependencies even if they are statically defined, this is not proper according
to EP 621. When property of the project is set to be dynamic, it also contains
static values. It's either static or dynamic.
This is not a problem for wheel packages when installed, by any standard
tool, because the wheel package has all the metadata added to wheel (and does
not contain pyproject.toml) but in various cases (such as installing airflow
via Github URL or from sdist, it can make a difference - depending whether the
tool installing airflow will use directly pyproject.toml for optimization, or
whether it will run build hooks to prepare the dependencies).
This change makes all optional dependencies dynamici - rather than bake them
in the pyproject.toml, we mark them as dynamic, so that any tool that uses
pyproject.toml or sdist PKG-INFO will know that it has to run build hooks to
get the actual optional dependencies.
There are a few consequences of that:
* our pyproject.toml will not contain automatically generated part - which
is actually good, as it caused some confusion
* all dynamic optional dependencies of ours are either present in
hatch_build.py or calculated there - this is a bit new but sounds reasonable -
and those dynamic dependencies are not really updated often, so thish is not an
issue to maintain them there
* the pre-commits that manage the optional dependencies got a lot simpler
now - a lot of code has been removed.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
