uranusjr commented on code in PR #38446:
URL: https://github.com/apache/airflow/pull/38446#discussion_r1537288111


##########
airflow/models/baseoperator.py:
##########
@@ -1001,6 +1005,7 @@ def __init__(
         self.doc_yaml = doc_yaml
         self.doc_rst = doc_rst
         self.doc = doc
+        self._task_display_name = task_display_name

Review Comment:
   Instead of trying to store the original value (making `_task_display_name` 
and `task_display_name` different values, which is confusing), it’s probably 
easier to just do
   
   ```python
   self.task_display_name = task_display_name or task_id
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to