moiseenkov commented on code in PR #38071:
URL: https://github.com/apache/airflow/pull/38071#discussion_r1537430263
##########
tests/providers/google/cloud/log/test_stackdriver_task_handler.py:
##########
@@ -67,6 +67,34 @@ def test_should_pass_message_to_client(mock_client,
mock_get_creds_and_project_i
mock_client.assert_called_once_with(credentials="creds",
client_info=mock.ANY, project="project_id")
[email protected]("clean_stackdriver_handlers")
[email protected]("airflow.providers.google.cloud.log.stackdriver_task_handler.get_credentials_and_project_id")
[email protected]("airflow.providers.google.cloud.log.stackdriver_task_handler.gcp_logging.Client")
+def test_should_use_configured_log_name(mock_client,
mock_get_creds_and_project_id):
+ mock_get_creds_and_project_id.return_value = ("creds", "project_id")
+
+ with mock.patch.dict(
+ "os.environ",
+ AIRFLOW__LOGGING__REMOTE_LOGGING="true",
+ AIRFLOW__LOGGING__REMOTE_BASE_LOG_FOLDER="stackdriver://host/path",
Review Comment:
If the new approach uses '///', should we apply it here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
