eladkal commented on code in PR #38458:
URL: https://github.com/apache/airflow/pull/38458#discussion_r1538056482
##########
airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -366,10 +366,17 @@ class KubernetesDeleteJobOperator(BaseOperator):
:param in_cluster: run kubernetes client with in_cluster configuration.
:param cluster_context: context that points to kubernetes cluster.
Ignored when in_cluster is True. If None, current-context is used.
(templated)
+ :param on_status: Condition for performing delete operation depending on
the job status. Values:
+ ``None`` - delete the job regardless of its status, "Complete" -
delete only successfully completed
+ jobs, "Failed" - delete only failed jobs. (default: ``None``)
+ :param wait_until_job_complete: Whether to wait for the job to complete.
(default: ``False``)
Review Comment:
I think the naming convention is `wait_for_completion` ? At least that is
what I see in many other operators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
