Re: [PR] Introducing --latest for generate-issue-content-core command [airflow]

Tue, 26 Mar 2024 00:54:41 -0700 


amoghrajesh commented on PR #38250:
URL: https://github.com/apache/airflow/pull/38250#issuecomment-2019683550

   > Hmm. The output still looks strange:
   > 
   > <img alt="Screenshot 2024-03-25 at 16 28 24" width="1237" 
src="https://private-user-images.githubusercontent.com/595491/316558024-2cdce197-b576-42f2-95c3-109d47dbc92d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE0MzkzNzEsIm5iZiI6MTcxMTQzOTA3MSwicGF0aCI6Ii81OTU0OTEvMzE2NTU4MDI0LTJjZGNlMTk3LWI1NzYtNDJmMi05NWMzLTEwOWQ0N2RiYzkyZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMzI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDMyNlQwNzQ0MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYTM0ODk5YmIzNTM1MTdiMTllODIzNzBmYjM4NzBhM2UxYThlMDVjNDA1Y2E1ZDk2ZDZkYjA1MzNmMmQ3OThkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.EnBIfdcSIQaXZejoj7F6dnuozkU2QrKyteSUO2wIIhg";>
   > I'd expect the actual list of issue since 2.8.3 (but maybe some other set 
of parameters is needed to generate these ?)
   
   I made it such that it would take the versions as latest and latest-rc1 if 
"VERSION" env is not set, since the latest and latest-rc1 wont have commits in 
between, it will show as 0 PRs.
   
   > I'd expect the actual list of issue since 2.8.3 (but maybe some other set 
of parameters is needed to generate these ?)
   
   To accomodate this use case, I have made the changes for it to take 'main'. 
My only worry is that now it will have 2000+ PRs, is that ok?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to